Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[c-ffi] Add a new error-condition result type. #803
Conversation
waywardmonkeys
reviewed
Jul 20, 2014
sources/dfmc/c-ffi/c-function-macro.dylan
| @@ -158,10 +159,15 @@ define method parse-early-options | ||
| collecting (return-values, arg-fragments, parameters, parameter-names) | ||
| let result-fragment = #f; | ||
| let vname = result-spec.name; | ||
| // 1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
waywardmonkeys
Jul 20, 2014
Member
I think this would be a bit more clear if this was error-result instead of error-condition so that it matches with result, especially for the warning about multiple results (which I was very glad to see you'd included).
|
I think this would be a bit more clear if this was |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
waywardmonkeys
Jul 20, 2014
Member
We'll also hold off on merging this until the documentation and release notes are updated!
|
We'll also hold off on merging this until the documentation and release notes are updated! |
fracek
added some commits
Jul 19, 2014
added a commit
that referenced
this pull request
Jul 22, 2014
fracek commentedJul 20, 2014
This helps writing better wrappers for C libraries where the
return value is used to signal if the function did error.