From c669a9c06c0035972cf4efbbecfd96a2a196d2c8 Mon Sep 17 00:00:00 2001 From: Dylan Smith Date: Wed, 9 Jan 2013 15:26:12 -0500 Subject: [PATCH] Fix JSON params parsing regression for non-object JSON content. Backports #8855. --- actionpack/CHANGELOG.md | 2 ++ actionpack/lib/action_dispatch/middleware/params_parser.rb | 4 ++-- .../test/dispatch/request/json_params_parsing_test.rb | 7 +++++++ 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index 62b003a815dc0..4ecf4a5e8633d 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,5 +1,7 @@ ## Rails 3.1.11 (unreleased) +* Fixed JSON params parsing regression for non-object JSON content. + ## Rails 3.1.10 (Jan 8, 2013) * Strip nils from collections on JSON and XML posts. [CVE-2013-0155] diff --git a/actionpack/lib/action_dispatch/middleware/params_parser.rb b/actionpack/lib/action_dispatch/middleware/params_parser.rb index aaf9680bedb73..41d7f0ad3606b 100644 --- a/actionpack/lib/action_dispatch/middleware/params_parser.rb +++ b/actionpack/lib/action_dispatch/middleware/params_parser.rb @@ -44,10 +44,10 @@ def parse_formatted_parameters(env) when :yaml YAML.load(request.raw_post) when :json - data = request.deep_munge ActiveSupport::JSON.decode(request.body) + data = ActiveSupport::JSON.decode(request.body) request.body.rewind if request.body.respond_to?(:rewind) data = {:_json => data} unless data.is_a?(Hash) - data.with_indifferent_access + request.deep_munge(data).with_indifferent_access else false end diff --git a/actionpack/test/dispatch/request/json_params_parsing_test.rb b/actionpack/test/dispatch/request/json_params_parsing_test.rb index a9ab1fd7fd3ca..a4b2259472f29 100644 --- a/actionpack/test/dispatch/request/json_params_parsing_test.rb +++ b/actionpack/test/dispatch/request/json_params_parsing_test.rb @@ -112,6 +112,13 @@ def teardown ) end + test "parses json with non-object JSON content" do + assert_parses( + {"user" => {"_json" => "string content" }, "_json" => "string content" }, + "\"string content\"", { 'CONTENT_TYPE' => 'application/json' } + ) + end + private def assert_parses(expected, actual, headers = {}) with_test_routing(UsersController) do