xml stream #2

Merged
merged 8 commits into from May 8, 2011

Conversation

Projects
None yet
2 participants
@dodo
Contributor

dodo commented Apr 30, 2011

i hope the code is not to ugly .. but it should work

the only api changes i made are, that when a xml.element is contained, it will return a readable stream, otherwise its a string like before.

the other change are the options. i like to use objects for options because its more readable code when its XML({foo:null}, {indent:true}) instead of just XML({foo:null}, true). if you don't like it, revert it.

the other option i added is that you can force the result to be a stream .. so even if XML could return a string it doesn't.

ps: i would like to see this feature in your other project node-atom (:

dylang added a commit that referenced this pull request May 8, 2011

@dylang dylang merged commit bd3981b into dylang:master May 8, 2011

@dylang

This comment has been minimized.

Show comment Hide comment
@dylang

dylang May 9, 2011

Owner

I haven't had time to figure out everything you've done but i'm happy with the tests and and features you added so i did a couple cleanups published the update. I hope you don't mind me adding you as a contributor in the package.json.

Owner

dylang commented May 9, 2011

I haven't had time to figure out everything you've done but i'm happy with the tests and and features you added so i did a couple cleanups published the update. I hope you don't mind me adding you as a contributor in the package.json.

@dodo

This comment has been minimized.

Show comment Hide comment
@dodo

dodo May 9, 2011

Contributor

no .. that's nice :]

Contributor

dodo commented May 9, 2011

no .. that's nice :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment