Dylan Schiemann dylans

  • SitePen, Inc.
  • Joined on

Organizations

@dojo @SitePen
dylans deleted branch updateversion1.10.4 at dylans/dojo-tutorials-1
dylans opened pull request SitePen/dojo-tutorials#2
@dylans
update Dojo version in tutorials to 1.10.4
1 commit with 452 additions and 452 deletions
@dylans
  • @dylans f69b59e
    update Dojo version in tutorials to 1.10.4
dylans commented on pull request dojo/dojox#177
@dylans

Thanks for this fix and test @ahmedasaleh . I would like to kindly suggest that any new tests be written as AMD rather than legacy dojo.require sty…

dylans closed pull request dojo/dojox#175
@dylans
#18570 Chart Indicator label positioning
dylans commented on pull request dojo/dojox#175
@dylans

Thanks for the fix, closed via 265915b .

dylans pushed to master at dojo/dojox
@dylans
  • @arunasr 265915b
    fixes #18570, Chart Indicator label positioning
dylans commented on pull request dojo/dojox#175
@dylans

btw, I think your original issue @arunasr might be that you were using the same branch for multiple pull requests... it's usually easier to use a s…

dylans commented on pull request dojo/dojox#175
@dylans

Ok, then I suggest a new branch and new pull request with the change, since it's just one line anyway. Also, please let me know which test(s) you'v…

dylans commented on pull request dojo/dojox#175
@dylans

You'll want to rebase this pull request against master, as it's including the changes for dojox/lang/functional also.

dylans closed pull request dojo/dojox#174
@dylans
#18533 dojox/lang/functional zip.js and curry.js in AMD style (broken in 1.10.4)
dylans commented on pull request dojo/dojox#174
@dylans

Thanks, closed via 7adb026

dylans pushed to master at dojo/dojox
@dylans
  • @arunasr 7adb026
    refs #18533, convert dojox/lang/functional zip.js and curry.js to AMD
dylans commented on pull request dojo/dojox#174
@dylans

Thanks for the pull request, I will review and land in the next week or so as time permits, unless someone beats me to it.

dylans commented on issue theintern/intern#384
@dylans

Yes, what @kitsonk said for DevTools a11y testing. For tenon.io, they have an API ( e.g. http://tenon.io/documentation/understanding-request-parame…

dylans commented on issue SitePen/dgrid#1121
@dylans

I see the issue in your screenshot, but it would really help if you could point to an example or testcase (e.g. can you reproduce this with one of …

@dylans
Automated accessibility testing
dylans pushed to master at dojo/dojox
@dylans
  • @dylans a9287d4
    refs #18565, missed a non-AMD dependency in the list of dojox/storage…
dylans closed pull request dojo/dojox#162
@dylans
Convert LocalStorageProvider to AMD
dylans commented on pull request dojo/dojox#162
@dylans

Thanks @jbest84 , this has landed in 79443fb . I made a few small formatting tweaks (there are more I could make, but I wanted to land this). Also …

dylans pushed to master at dojo/dojox
@dylans
  • @dylans 79443fb
    refs #18565, Convert LocalStorageProvider to AMD
dylans commented on issue SitePen/dgrid#1122
@dylans

Are you using OnDemandGrid? I assume you're not actually trying to render all 2000 rows of data? What other mixins are you including?

dylans pushed to 1.8 at dojo/dojox
@dylans
  • @neonstalwart 1317541
    refs #17661, fix for when options are not passed to socket/Reconnect
dylans pushed to 1.9 at dojo/dojox
@dylans
  • @neonstalwart 04fc532
    refs #17661, fix for when options are not passed to socket/Reconnect
dylans pushed to 1.10 at dojo/dojox
@dylans
dylans closed pull request dojo/dojox#158
@dylans
Socket reconnect
dylans commented on pull request dojo/dojox#158
@dylans

Thanks for the fix, closed via 5a7969c

dylans pushed to master at dojo/dojox
@dylans
  • @neonstalwart 5a7969c
    refs #17661, fix for when options are not passed to socket/Reconnect