From 829f09f5b7863268e17434442be3614bf8276e0b Mon Sep 17 00:00:00 2001 From: Severin Neumann Date: Wed, 5 May 2021 19:30:57 +0200 Subject: [PATCH] docs: Explicitly state that express instrumentation does not export spans without http instrumentation (#472) As discussed in the meeting today, I think making this point clear helps enduser to understand what they _might_ be doing wrong if no spans are exported. Co-authored-by: Valentin Marchaud --- plugins/node/opentelemetry-instrumentation-express/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/node/opentelemetry-instrumentation-express/README.md b/plugins/node/opentelemetry-instrumentation-express/README.md index ae2d75749be..2a9404d9ad9 100644 --- a/plugins/node/opentelemetry-instrumentation-express/README.md +++ b/plugins/node/opentelemetry-instrumentation-express/README.md @@ -12,7 +12,7 @@ For automatic instrumentation see the ## Installation -This instrumentation relies on HTTP calls to also be instrumented. Make sure you install and enable both. +This instrumentation relies on HTTP calls to also be instrumented. Make sure you install and enable both, otherwise you will not see any spans being exported from the instrumentation. ```bash npm install --save @opentelemetry/instrumentation-http @opentelemetry/instrumentation-express