From 20d99790ed4eae0578cc496b5f83ab81d1008330 Mon Sep 17 00:00:00 2001 From: Lara Aigmueller Date: Thu, 19 Mar 2020 09:39:22 +0100 Subject: [PATCH] barista: Use images instead of inline svgs for icons. --- apps/barista-design-system/src/app/app.html | 2 +- .../src/app/components/footer/footer.html | 46 +------------- .../scroll-to-top/scroll-to-top.html | 10 +-- .../scroll-to-top/scroll-to-top.scss | 1 - .../src/assets/arrow-up-white.svg | 1 + .../src/assets/behance-white.svg | 1 + .../src/assets/dribbble-white.svg | 1 + .../src/assets/favorite-white.svg | 1 + .../src/assets/github-white.svg | 1 + .../src/assets/incident-white.svg | 1 + .../src/assets/laboratory-white.svg | 1 + .../src/assets/list-view.svg | 1 + .../src/assets/maintenance-royalblue.svg | 1 + .../src/assets/tile-view.svg | 1 + .../overview-page/components/tile/tile.html | 63 ++++++------------- .../overview-page/components/tile/tile.scss | 12 +--- .../pages/overview-page/overview-page.html | 12 +--- .../pages/overview-page/overview-page.scss | 3 +- .../icon-overview-content.ts | 1 - 19 files changed, 38 insertions(+), 122 deletions(-) create mode 100644 apps/barista-design-system/src/assets/arrow-up-white.svg create mode 100644 apps/barista-design-system/src/assets/behance-white.svg create mode 100644 apps/barista-design-system/src/assets/dribbble-white.svg create mode 100644 apps/barista-design-system/src/assets/favorite-white.svg create mode 100644 apps/barista-design-system/src/assets/github-white.svg create mode 100644 apps/barista-design-system/src/assets/incident-white.svg create mode 100644 apps/barista-design-system/src/assets/laboratory-white.svg create mode 100644 apps/barista-design-system/src/assets/list-view.svg create mode 100644 apps/barista-design-system/src/assets/maintenance-royalblue.svg create mode 100644 apps/barista-design-system/src/assets/tile-view.svg diff --git a/apps/barista-design-system/src/app/app.html b/apps/barista-design-system/src/app/app.html index 22811a7292..35de050c2a 100644 --- a/apps/barista-design-system/src/app/app.html +++ b/apps/barista-design-system/src/app/app.html @@ -19,7 +19,7 @@ - + diff --git a/apps/barista-design-system/src/app/components/footer/footer.html b/apps/barista-design-system/src/app/components/footer/footer.html index 32cd510dc4..315be8b3eb 100644 --- a/apps/barista-design-system/src/app/components/footer/footer.html +++ b/apps/barista-design-system/src/app/components/footer/footer.html @@ -5,59 +5,19 @@

Join us on

href="https://github.com/dynatrace-oss/barista" class="ba-footer-sociallink ba-btn ba-btn-secondary" > - - Github - - - - + Dynatrace on GitHub - - Behance - - - - - - + Dynatrace on Behance - - Dribbble - - - - + Dynatrace on Dribbble
-
- {{ data.identifier }} +
+ {{ data.identifier }}
{{ data.title }}
diff --git a/apps/barista-design-system/src/pages/overview-page/components/tile/tile.scss b/apps/barista-design-system/src/pages/overview-page/components/tile/tile.scss index c286a67eb2..a5f123bf57 100644 --- a/apps/barista-design-system/src/pages/overview-page/components/tile/tile.scss +++ b/apps/barista-design-system/src/pages/overview-page/components/tile/tile.scss @@ -42,9 +42,8 @@ $gridgap: 20px; fill: #ffffff; } - svg { + img { transform: rotate(90deg); - fill: $link-color; } } } @@ -84,17 +83,11 @@ $gridgap: 20px; font-size: 1.2rem; } - .ba-tile-img { + .ba-tile-identifier { font-size: $tilefontsize-big; margin-right: 1.5rem; min-width: 60px; text-align: center; - - svg { - max-width: 50px; - height: 100%; - vertical-align: middle; - } } .ba-tile-type { @@ -132,7 +125,6 @@ $gridgap: 20px; position: absolute; top: 3px; right: 5px; - fill: #ffffff; } } diff --git a/apps/barista-design-system/src/pages/overview-page/overview-page.html b/apps/barista-design-system/src/pages/overview-page/overview-page.html index 8ee05c5ef6..086d819250 100644 --- a/apps/barista-design-system/src/pages/overview-page/overview-page.html +++ b/apps/barista-design-system/src/pages/overview-page/overview-page.html @@ -11,11 +11,7 @@

{{ content.title }}

aria-label="Show links to subpages as list items." (click)="_switchOverviewPageDisplay()" > - - - + List view icon
diff --git a/apps/barista-design-system/src/pages/overview-page/overview-page.scss b/apps/barista-design-system/src/pages/overview-page/overview-page.scss index 98653422eb..93dcd5af2c 100644 --- a/apps/barista-design-system/src/pages/overview-page/overview-page.scss +++ b/apps/barista-design-system/src/pages/overview-page/overview-page.scss @@ -87,8 +87,7 @@ ul { line-height: 1; padding: 4px 12px; - svg { - fill: $gray-700; + img { width: 28px; height: 28px; } diff --git a/apps/barista-design-system/src/pages/single-page/components/icon-overview-content/icon-overview-content.ts b/apps/barista-design-system/src/pages/single-page/components/icon-overview-content/icon-overview-content.ts index 1464d32098..88ccf7162a 100644 --- a/apps/barista-design-system/src/pages/single-page/components/icon-overview-content/icon-overview-content.ts +++ b/apps/barista-design-system/src/pages/single-page/components/icon-overview-content/icon-overview-content.ts @@ -111,7 +111,6 @@ export class BaIconOverviewContent implements OnInit, AfterViewInit, OnDestroy { * the icon's name or in the list of tags. */ export function filterIcons(icons: BaIcon[], filterValue: string): BaIcon[] { - console.log(filterValue); if (!filterValue.length) { return icons; }