Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpatch build is confused by kstrtab symbols #40

Closed
jpoimboe opened this issue Mar 3, 2014 · 1 comment
Closed

kpatch build is confused by kstrtab symbols #40

jpoimboe opened this issue Mar 3, 2014 · 1 comment

Comments

@jpoimboe
Copy link
Member

jpoimboe commented Mar 3, 2014

Junliang Li reported this on the mailing list. The following patch fails:

Index: src/drivers/scsi/constants.c
===================================================================
--- src.orig/drivers/scsi/constants.c
+++ src/drivers/scsi/constants.c
@@ -1546,6 +1546,8 @@ void scsi_print_sense(char *name, struct
 {
    struct scsi_sense_hdr sshdr;

+   printk(KERN_INFO "\nkpatch code\n");
+
    scmd_printk(KERN_INFO, cmd, " ");
    scsi_decode_sense_buffer(cmd->sense_buffer, SCSI_SENSE_BUFFERSIZE,
                 &sshdr);

It fails with:

create-diff-object: kpatch_create_symbol_table: 372: local symbol __kstrtab_scsi_show_result starts at section offset 18, expected 0

It's getting confused by the __kstrtab_scsi_show_result symbol, which I think is created because of EXPORT_SYMBOL(scsi_show_result).

@sjenning
Copy link
Contributor

sjenning commented Mar 5, 2014

Fixed by f6efd53

@sjenning sjenning closed this as completed Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants