Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't ignore changes to arch/x86/kvm/../../../virt/kvm/kvm_main.o #735

Closed
jpoimboe opened this issue Sep 12, 2017 · 0 comments
Closed

don't ignore changes to arch/x86/kvm/../../../virt/kvm/kvm_main.o #735

jpoimboe opened this issue Sep 12, 2017 · 0 comments

Comments

@jpoimboe
Copy link
Member

This was broken with #687.
jpoimboe pushed a commit to jpoimboe/kpatch that referenced this issue Sep 14, 2017
@txxxggg @jpoimboe
kpatch: fix kpatch-build matching changed object bug
ec98604 
When there is a ".." in the source object path, kpatch-gcc can't handle
it correctly.  kpatch-gcc is called for objects which were recompiled
and writes the changed objects to "changed_objs". But if the path of the
input obj is something like:

  arch/x86/kvm/../../../virt/kvm/.tmp_kvm_main.o

then it will fall into the "*.*.o" branch of the kpatch-gcc case
statement and kpatch-build will report "ERROR: no changed objects
found."

Use Joe's suggestion to revert d526805 ("kpatch-gcc: update
ignorelist to avoid foo/.lib_exports.o files") and instead add a
"*/.lib_exports.o" pattern.

Fixes dynup#735.

[ cleaned up changelog - jpoimboe@redhat.com ]

Cc: Joe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: chen xiaoguang <xiaoggchen@tencent.com>
@jpoimboe jpoimboe mentioned this issue Sep 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpoimboe