Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crux-ui): npm install target script #227

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix(crux-ui): npm install target script #227

merged 2 commits into from
Oct 19, 2022

Conversation

princefishthrower
Copy link
Contributor

This should solve the issue raised in #224

@polaroi8d
Copy link
Collaborator

polaroi8d commented Oct 2, 2022 •
edited

GPG commit signature is missing and the wrong commit message. Please read CONTRIBUTING.md for more information.

@polaroi8d polaroi8d requested a review from a team October 2, 2022 17:18
@polaroi8d polaroi8d added issue:enhancement New feature or request issue:hacktoberfest Issue marked as suitable for Hacktoberfest labels Oct 2, 2022
@polaroi8d polaroi8d mentioned this pull request Oct 3, 2022
Closed
@polaroi8d polaroi8d linked an issue Oct 3, 2022 that may be closed by this pull request
Add target x64 install to package.json #224
Closed
polaroi8d
polaroi8d reviewed Oct 4, 2022
View reviewed changes
web/crux-ui/package.json Outdated Show resolved Hide resolved
@polaroi8d polaroi8d added source:web The scope of the issue or pull request is web. pr:fix labels Oct 4, 2022
@polaroi8d
Copy link
Collaborator

@princefishthrower could you please update the PR based on the reviews?

@polaroi8d polaroi8d changed the title Fix for #224 - add install for x86 architecture fix(crux-ui): npm install target script Oct 18, 2022
robot9706
robot9706 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@polaroi8d polaroi8d merged commit 6f8d271 into dyrector-io:develop Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d left review comments

@m8vago m8vago m8vago approved these changes

@robot9706 robot9706 robot9706 approved these changes

Assignees
No one assigned
Labels
issue:enhancement New feature or request issue:hacktoberfest Issue marked as suitable for Hacktoberfest pr:fix source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add target x64 install to package.json
4 participants
@princefishthrower @polaroi8d @m8vago @robot9706