Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[partial][common] log #60
Conversation
This comment has been minimized.
This comment has been minimized.
Hey maybe you would like this: https://about.pullapprove.com/ always_pending:
title_regex: 'WIP'
explanation: 'Work in progress...' |
This comment has been minimized.
This comment has been minimized.
@arrowrowe hey maybe I should put mie on fire and brush some oil @mingo-x |
This comment has been minimized.
This comment has been minimized.
@at15 you didn't set the wip rule... |
added a commit
that referenced
this pull request
Dec 17, 2016
at15
added some commits
Dec 16, 2016
at15
force-pushed the
common-util/log
branch
from
a40f76a
to
1a07fe9
Dec 17, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 17, 2016
•
at15
added some commits
Dec 17, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 17, 2016
•
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 18, 2016
•
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 18, 2016
•
at15
added some commits
Dec 18, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 18, 2016
•
at15
added
the
type/backlog
label
Dec 18, 2016
at15
changed the title
[WIP][common] log
[partial][common] log
Dec 18, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
at15
merged commit b357803
into
master
Dec 18, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Dec 18, 2016
at15
deleted the
common-util/log
branch
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
at15 commentedDec 16, 2016
•
edited
Related #59
It is basic a clone of logrus with the following modification
Debug, Warn
inLogger
, only keep those methods onEntry
interface{}
Logger
)\n
for*f
functionslogger.NewEntryWithPkg("x.tsdb.kairosdb")
the more detail description can be found in README, all the logrus usage are replaced with
common/log
, and sinceWithField
is not supported, it is replaced by*f
....