From 450b2ef2bb905977bcc0d70d648086be1f2ec04c Mon Sep 17 00:00:00 2001
From: at15 <at15@outlook.com>
Date: Sat, 4 May 2019 13:55:14 -0700
Subject: [PATCH] [release] 0.0.12

---
 CHANGELOG.md            | 10 ++++++++++
 Makefile                |  8 ++++----
 ROADMAP.md              |  9 +++++++--
 hack/docker-compose.yml |  9 ++++-----
 4 files changed, 25 insertions(+), 11 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 93bbd42..7a59199 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## v0.0.12
+
+Released on 2019/05/04
+
+[release](https://github.com/dyweb/gommon/releases/tag/0.0.12) [closed issues](https://github.com/dyweb/gommon/issues?q=is%3Aclosed+milestone%3A0.0.12)
+
+New feature
+
+- [#114](https://github.com/dyweb/gommon/issues/114) move httpclient library from [go.ice](https://github.com/dyweb/go.ice)
+
 ## v0.0.11
 
 Released on 2019/04/28
diff --git a/Makefile b/Makefile
index 391d2e8..7f656f2 100644
--- a/Makefile
+++ b/Makefile
@@ -35,7 +35,7 @@ GO = GO111MODULE=on go
 # -- build vars ---
 PKGS =./errors/... ./generator/... ./httpclient/... ./log/... ./noodle/... ./util/...
 PKGST =./cmd ./errors ./generator ./httpclient ./log ./noodle ./util
-VERSION = 0.0.11
+VERSION = 0.0.12
 BUILD_COMMIT := $(shell git rev-parse HEAD)
 BUILD_TIME := $(shell date +%Y-%m-%dT%H:%M:%S%z)
 CURRENT_USER = $(USER)
@@ -135,10 +135,10 @@ docker-build:
 docker-push:
 	docker push $(DOCKER_REPO):$(VERSION)
 
-# TODO: deprecated docker-compose based test
 docker-test:
-	docker-compose -f scripts/docker-compose.yml run --rm golang1.10
-	docker-compose -f scripts/docker-compose.yml run --rm golanglatest
+	docker-compose -f hack/docker-compose.yml run --rm golang1.12
+# TODO: not sure why the latest one is not using ...
+#	docker-compose -f hack/docker-compose.yml run --rm golanglatest
 
 #.PHONY: docker-remove-all-containers
 #docker-remove-all-containers:
diff --git a/ROADMAP.md b/ROADMAP.md
index f5d63c2..fb3ec93 100644
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@ -4,6 +4,9 @@
 
 ### 0.0.13
 
+Was 0.0.12 but move httpclient from go.ice is needed and improve the error package is going to take a while,
+so changed milestone to 0.0.13.
+
 - [ ] align errors with x/errors which will become the default [#109](https://github.com/dyweb/gommon/issues/109)
 
 From 0.0.11
@@ -21,12 +24,14 @@ From 0.0.9
 - [ ] explain internals of some implementation
 - [ ] (optional) extension for collecting errors using third party services
 
-### 0.0.12
 
-- [ ] move httpclient from go.ice
 
 ## Finished
 
+### 0.0.12
+
+- [x] move httpclient from go.ice
+
 ### 0.0.11
 
 - [x] simplify log package [#110](https://github.com/dyweb/gommon/issues/110)
diff --git a/hack/docker-compose.yml b/hack/docker-compose.yml
index 6de4177..4570ac7 100644
--- a/hack/docker-compose.yml
+++ b/hack/docker-compose.yml
@@ -1,15 +1,14 @@
 version: '3'
 services:
-# FIXME: there should be a way of reusing command, I am just copying stuff around, there is extend keyword, but removed in v3
-  golang1.10:
-    image: golang:1.10
-    command: go test -v -cover ./errors/... ./generator/... ./log/... ./playground/... ./requests/... ./structure/... ./util/...
+  golang1.12:
+    image: golang:1.12
+    command: make test
     working_dir: /go/src/github.com/dyweb/gommon
     volumes:
      - "..:/go/src/github.com/dyweb/gommon:rw"
   golanglatest:
     image: golang:latest
-    command: go test -v -cover ./errors/... ./generator/... ./log/... ./playground/... ./requests/... ./structure/... ./util/...
+    command: make test
     working_dir: /go/src/github.com/dyweb/gommon
     volumes:
      - "..:/go/src/github.com/dyweb/gommon:rw"
\ No newline at end of file