Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options for Sqlite backend #1

Merged
merged 2 commits into from Mar 15, 2018
Merged

Added options for Sqlite backend #1

merged 2 commits into from Mar 15, 2018

Conversation

pbv
Copy link
Contributor

@pbv pbv commented Mar 14, 2018

Hello,
I've added some options to allow using the Snap.Auth.Sqlite backend; maybe you'd like review these and merge them into your repository.

Copy link
Owner

@dzhus dzhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the patch, I'm going to ask you to put in a few lines in README.md too to document this (as it no longer supports only JSON)

@pbv
Copy link
Contributor Author

pbv commented Mar 14, 2018

Before I do that let me point out that I did a quick hack and changed the options semantics slightly: instead of -j file you need to use -j -f file (for Json) or -s -f file (for Sqlite). I couldn't figure a way to parsing an enumeration with fields using implicit arguments and didn't want to rewrite the option parsing using a lower level library.
This may break existing scripts; if you're OK with this I'll modify the README.

@dzhus
Copy link
Owner

dzhus commented Mar 14, 2018

@pbv Of course, the change makes sense, and I think it's perfectly fine as long as it's documented. I'll use this as a chance to start a CHANGELOG too.

@pbv
Copy link
Contributor Author

pbv commented Mar 14, 2018

OK, I've updated the README file.

@pbv pbv closed this Mar 15, 2018
@dzhus
Copy link
Owner

dzhus commented Mar 15, 2018

@pbv Did you find an issue or was the PR closed by accident?

@pbv pbv reopened this Mar 15, 2018
@pbv
Copy link
Contributor Author

pbv commented Mar 15, 2018

Sorry, my mistake

@dzhus dzhus merged commit 5991021 into dzhus:master Mar 15, 2018
@dzhus
Copy link
Owner

dzhus commented Mar 30, 2018

@pbv This has now been pushed to Hackage as 0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants