New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML exporter doesn't export upfiles in ZIP mode #514

Open
edemaine opened this Issue Feb 9, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@edemaine

edemaine commented Feb 9, 2016

forum_modules/exporter/exporter.py's export_upfiles() just creates an "upfiles" directory, which never gets populated with the uploaded files (at least in ZIP mode -- this seems to be the behavior of ZipFile). It shouldn't be hard to list and write the files over from forum/upfiles, so I'm planning to do that. Would you accept a patch to this effect?

@edemaine

This comment has been minimized.

Show comment
Hide comment
@edemaine

edemaine Feb 9, 2016

I confirmed that the tar.gz export works fine. So, recursion is automatic for tarfile but not zipfile. I added a pull request #515 that fixes export_upfiles() in the ZIP case, via os.listdir. (Fixing export_skinsfolder for ZIP export would require os.walk, which I haven't done.)

edemaine commented Feb 9, 2016

I confirmed that the tar.gz export works fine. So, recursion is automatic for tarfile but not zipfile. I added a pull request #515 that fixes export_upfiles() in the ZIP case, via os.listdir. (Fixing export_skinsfolder for ZIP export would require os.walk, which I haven't done.)

@edemaine edemaine changed the title from XML exporter doesn't export upfiles to XML exporter doesn't export upfiles in ZIP mode Feb 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment