Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drone extraction module / Silent mode #993

Merged
merged 50 commits into from
Jan 29, 2024
Merged

Drone extraction module / Silent mode #993

merged 50 commits into from
Jan 29, 2024

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Jan 16, 2024 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

See #975
See #994
See #461

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

Closes #975
Closes #994
Closes #461

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Absolutely ... we can test DJI drones much better
We have a silent mode with enabled status bar. This can be enabled with the -B parameter and shows primarly the emba.log with the well known EMBA status bar:

image

@m-1-k-3 m-1-k-3 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers EMBA labels Jan 16, 2024
@m-1-k-3 m-1-k-3 mentioned this pull request Jan 17, 2024
Closed
@m-1-k-3 m-1-k-3 changed the title Drone extraction module Drone extraction module / Silent mode Jan 24, 2024
@m-1-k-3 m-1-k-3 marked this pull request as ready for review January 26, 2024 08:06
@m-1-k-3
Copy link
Member Author

m-1-k-3 commented Jan 26, 2024

Lets finish this beast ;)
@HoxhaEndri @BenediktMKuehne @jblu42 could you please give it a try. Very interested in your feedback around the new silent mode ... -B

@BenediktMKuehne
Copy link
Member

Will do a test-run

@m-1-k-3 m-1-k-3 merged commit c4ac89e into e-m-b-a:master Jan 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

@HoxhaEndri HoxhaEndri Awaiting requested review from HoxhaEndri

@jblu42 jblu42 Awaiting requested review from jblu42

Assignees
No one assigned
Labels
EMBA enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update minimum size requirement Drone firmware testing support Status bar rendering stability
3 participants
@m-1-k-3 @BenediktMKuehne @jblu42