Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Banners Plugin #3141

Closed
LaocheXe opened this issue May 23, 2018 · 5 comments

Comments

@LaocheXe
Copy link
Contributor

commented May 23, 2018

I enabled the Banners plugin, added the menu into the menu manager in area 2, wont show, did the same in area 104 - no show, even clicked on the e107promo in menu manager banners config - (by the way, broken lans in the menu manager banners config area) - still nothing is showing up. - even tried to debug, and nothing is showing for the banners plugin

@Moc Moc added the bug label Jun 23, 2018

@Moc Moc added this to the e107 2.1.9 milestone Jun 23, 2018

@Moc Moc added the plugin: banner label Jun 23, 2018

@Moc

This comment has been minimized.

Copy link
Member

commented Jun 23, 2018

Confirmed

  1. Banner not showing up in the assigned menu area
  2. Broken LAN in menu configure area
@LaocheXe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2018

I notice {BANNER} shortcode works, sort of - didn't add any parameters to it

bannertest

@Moc

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

I've made some changes:

  • LAN fixed
  • The only thing you need to do after activating the menu in a particular area, is configure which campaign needs to be shown.
@Moc

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@CaMer0n is it possible to set a default value for a menu pref? Perhaps we can improve the banner plugin by making the default banner (that is inserted during plugin install) show by default.

@CaMer0n

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

@Moc Usually I use varset($pref, 'defaultvalue'); inside the menu itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.