Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login error message is loaded 2x #3470

Closed
Jimmi08 opened this issue Sep 27, 2018 · 6 comments · Fixed by #4734
Closed

login error message is loaded 2x #3470

Jimmi08 opened this issue Sep 27, 2018 · 6 comments · Fixed by #4734
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Sep 27, 2018

Errors after submit login form are displayed twice
image

removing {LOGIN_TABLE_LOGINMESSAGE} from template didn't help
image

If this is duplicate issue, sorry, I couldn't find it, but I think that this was mentioned already.

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Sep 27, 2018
@Moc Moc added this to the e107 2.2.0 milestone Sep 30, 2018
@mostym
Copy link

mostym commented Jan 17, 2019

I'm experiencing this bug as well. Any possible fix would be lovely :D

image

@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 1, 2019
@Moc Moc self-assigned this Feb 1, 2019
@Moc
Copy link
Member

Moc commented Feb 7, 2019

@mostym Is this still an issue? I cannot reproduce it atm.

@mostym
Copy link

mostym commented Feb 7, 2019

@Moc Yes, it's still an issue for me.

@Moc Moc removed their assignment Feb 9, 2019
@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 9, 2019
@Moc
Copy link
Member

Moc commented Feb 28, 2019

Confirmed. I have the same issue on my theme. Caused by LOGINMESSAGE.
Not sure what the best fix is.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 23, 2019

Possible fix :

instead:

echo LOGINMESSAGE;

use it only for modal login:

          if(deftrue('e_IFRAME'))
            {  
              echo LOGINMESSAGE;
            }    

@CaMer0n CaMer0n modified the milestones: e107 2.2.0, e107 2.2.1 May 18, 2019
@CaMer0n CaMer0n modified the milestones: e107 2.2.1, e107 2.2.2 May 28, 2019
@CaMer0n CaMer0n modified the milestones: e107 2.3.0, e107 2.3.1 Dec 1, 2020
@CaMer0n CaMer0n modified the milestones: e107 2.3.1, e107 2.3.2 Dec 2, 2021
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 14, 2022

Not sure when this was fixed, but it looks correct now. At least with core templates

Edit: it is correct with the login modal box. With login as a standard page (e_IFRAME is used), the problem is still there.
According to our old discussion with Cam. , using login as modal is the core way, and other ways are workarounds and not supported, I left this as closed...

@Jimmi08 Jimmi08 closed this as completed Mar 14, 2022
@CaMer0n CaMer0n reopened this Mar 15, 2022
CaMer0n added a commit that referenced this issue Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants