New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with {NEWSIMAGE} shortcode #3478

Open
Jimmi08 opened this Issue Sep 29, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Jimmi08
Contributor

Jimmi08 commented Sep 29, 2018

there is always attribute style
image

because it's inline styling, it can't be fixed in css

This is correct:

		$imgParms = array(
			'class'=>$class,
			'alt'=>basename($srcPath),
			'style'=>$style,
			'placeholder'=>varset($parm['placeholder'])
		);

but $style is filled this way:
$style = !empty($this->param['thumbnail']) ? $this->param['thumbnail'] : '';

and this is filled from this:
param['thumbnail'] =(defined("NEWSLIST_THUMB")) ? NEWSLIST_THUMB : "border:0px";

only way how to fix it was to define constant
define('NEWSLIST_THUMB', '');

Is this desired way or it's something old?

@rica-carv

This comment has been minimized.

Contributor

rica-carv commented Sep 29, 2018

Agree, but as a remark, if you use !important in your css rule, won't it override the inline style?

@CaMer0n

This comment has been minimized.

Member

CaMer0n commented Sep 30, 2018

It's a backward compatibility thing. Maybe you can try removing 'border:0px' from the code above on some of the v1.x upgraded sites (using v1 themes) and see how they look? (eg wrxxy )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment