We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For testing purposes using both versions: {LEVEL=pic} {LEVEL=glyph}
First user is always correct: (one star both)
Next user shows 11 stars (because there is no image for 11 star it looks like without rank)
Only default ranks are used. After trying to find a reason, ranks for next users (except first one) are:
[10] => Array ( [name] => Level 10 [thresh] => 1500 [lan_pfx] => 0 [image] => lev10.png [id] => 1326 ) [0] => Array ( [thresh] => )
for third one:
[0] => Array ( [thresh] => ) [11] => Array ( [name_parsed] => )
etc... so this is not correct: $lastRank = count($this->ranks['data']) and stars count for default rank is wrong.
$lastRank = count($this->ranks['data'])
After checking the code I noticed:
ranks keys for data subarray should be 1 ... 10 - it is correct
but foreach for it is going from 0 - 9 for($i=0; $i < $lastRank; $i++)
for($i=0; $i < $lastRank; $i++)
check of default level is - if($level <= varset($this->ranks['data'][0]['thresh'])) but there shouldn't be this value with key 0
- if($level <= varset($this->ranks['data'][0]['thresh']))
I couldn't find a reason why the ranks array was changed, so maybe there is other reason
displaying default level - one star for both shortcodes
The text was updated successfully, but these errors were encountered:
Merge pull request #4735 from Jimmi08/rank-issue-for-first-level
c510885
Fixes #4670 ranks issue for first level
Jimmi08
Successfully merging a pull request may close this issue.
Bug Description
For testing purposes using both versions:
{LEVEL=pic}
{LEVEL=glyph}
First user is always correct: (one star both)
Next user shows 11 stars (because there is no image for 11 star it looks like without rank)
Only default ranks are used.
After trying to find a reason, ranks for next users (except first one) are:
for third one:
etc...
so this is not correct:
$lastRank = count($this->ranks['data'])
and stars count for default rank is wrong.
After checking the code I noticed:
ranks keys for data subarray should be 1 ... 10 - it is correct
but foreach for it is going from 0 - 9
for($i=0; $i < $lastRank; $i++)
check of default level is
- if($level <= varset($this->ranks['data'][0]['thresh']))
but there shouldn't be this value with key 0
I couldn't find a reason why the ranks array was changed, so maybe there is other reason
How to Reproduce
Expected Behavior
displaying default level - one star for both shortcodes
The text was updated successfully, but these errors were encountered: