Login flow consistency: Do not use redirect in admin area login box - #4865
Merged
Conversation
The non-admin login flow does not perform a redirect, but the admin login flow did. This led to an inconsistency in how the authentication error message was passed. Fixes: e107inc#4779
|
Code Climate has analyzed commit 00b1d75 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 25.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.4% (0.1% change). View more on Code Climate. |
Member
|
Thank you! 👍 |
Deltik
pushed a commit
that referenced
this pull request
Jul 26, 2026
Fixes: #4779 Login flow consistency: Do not use redirect in admin area login box
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4779
Motivation and Context
The non-admin login flow does not perform a redirect, but the admin login flow did. This led to an inconsistency in how the authentication error message was passed.
Description
The login failure redirect on the admin area login page (
/e107_admin/admin.php) has been removed.How Has This Been Tested?
\AdminLoginCest::testAdminFailedLogin()now checks that the login failure message is displayed in the admin area login page on failed login.Types of Changes
Checklist