news: Fix category link in both breadcrumb and menu

[Deltik]

Motivation and Context

These changes fixed individual symptoms, but not the root cause:

• ba18155 broke the news plugin category breadcrumb in an effort to fix the category list in the news_categories menu.
• Fix news category breadcrumbs #4982 fixed that category breadcrumb but broke the friendly name for search engine-friendly URLs.

Description

This change reverts both failed fixes and actually addresses the root cause: When rendering the category list, read out the category_id, and e_news_category_item::sc_news_category_url() should be passing in category_id, not id. id cannot mean both the category ID and the news item ID.

How Has This Been Tested?

Manually, I checked both the news_categories menu behavior and the breadcrumb behavior on all news SEF variants at /e107_admin/eurl.php?mode=main&action=config.

Automated tests for the news plugin category SEF URLs are in the new file e107_tests/tests/unit/plugins/news/PluginNewsTest.php.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[qlty-cloud-legacy]

Code Climate has analyzed commit 1d1f4d0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.7% (0.0% change).

View more on Code Climate.

[CaMer0n]

Excellent! Thanks @Deltik