install.php: PHP 8.2 exception handler signature compatibility - #5073
Merged
Conversation
The exception handler parameter has to be of type `Throwable`, but we are remaining compatible with PHP 5.6, which didn't have `Throwable`, so let's fix this by moving the type to the phpDoc block. Fixes: e107inc#5072
|
Code Climate has analyzed commit c6401ff and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.7% (0.1% change). View more on Code Climate. |
Deltik
pushed a commit
that referenced
this pull request
Jul 26, 2026
install.php: PHP 8.2 exception handler signature compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes: #5072
Description
The exception handler parameter has to be of type
Throwable, but we are remaining compatible with PHP 5.6, which didn't haveThrowable, so let's fix this by moving the type to the phpDoc block.How Has This Been Tested?
Human static code analysis?
Types of Changes
Checklist