feat: rework toSpliced codemod #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`splice` doesn't return the mutated array, so this is a major rethink of the codemod to instead match the following: ```ts const arr = original.slice(); arr.splice(0, 1); ``` Note it currently only works with semi-colons and `const`.
43081j
force-pushed
the
spliced-rework
branch
from
7fa68ef to
3c24d14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splicedoesn't return the mutated array, so this is a major rethink ofthe codemod to instead match the following:
Note it currently only works with semi-colons and
const.