-
Notifications
You must be signed in to change notification settings - Fork 182
Add connect method #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakubno
merged 9 commits into
main
from
fix-bug-when-connecting-to-a-sandbox-with-longer-timeout-api-eng-3232
Oct 29, 2025
Merged
Add connect method #1413
jakubno
merged 9 commits into
main
from
fix-bug-when-connecting-to-a-sandbox-with-longer-timeout-api-eng-3232
Oct 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitole
requested changes
Oct 29, 2025
sitole
approved these changes
Oct 29, 2025
|
Please sync in https://e2b-team.slack.com/archives/C026MLBNSKC/p1761752064740269?thread_ts=1761729689.300479&cid=C026MLBNSKC before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds POST
/sandboxes/{sandboxID}/connectto return/resume sandboxes and extend TTL, updates spec/types/clients, deprecates resume, and adds integration tests.POST /sandboxes/{sandboxID}/connecthandlerPostSandboxesSandboxIDConnectto return running sandbox (200) or resume from snapshot (201) and extend TTL; validates timeout vs team limits and handles state transitions.ConnectSandboxschema and request bodyPostSandboxesSandboxIDConnectJSONRequestBody.ServerInterface, middleware, and Gin router inpackages/api/internal/api/api.gen.go.spec.gen.go) and types (types.gen.go).POST /sandboxes/{sandboxID}/resumeas deprecated.tests/integration/internal/api/client.gen.go) and models (models.gen.go).sandbox_connect_test.gocovering paused/running, TTL extension, not-found, oversized timeout, and concurrent connects.sandbox_refresh_test.gofor TTL refresh behavior.sandbox_set_timeout_test.gowithsandbox_timeout_test.goconsolidating timeout cases.Written by Cursor Bugbot for commit 5729df8. This will update automatically on new commits. Configure here.