Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload e2guardian not reload ipgroups after changing ip address from filter group to other filter group #458

Closed
Anthony-76 opened this issue Oct 2, 2018 · 9 comments
Assignees

Comments

@Anthony-76
Copy link

Hi,

I use E2guardian 5.2.1 on Debian 9

I change my IP address from filter 1 to filter2 in /etc/e2guardian/lists/authplugins/ipgroups.
Then I do e2guardian -r. When I see on access.log, my IP @ is on the same filer (filter1 not filter2)

I saw in the past the issue #158. The same issue of mine

I do e2guardian -g and the result is the same than e2guardian -r.

In order to take in consideration my conf, I need to restart E2guardian

So, E2guardian is able to reload change in filtergroupslist file without restart E2guardian?
If not, is it possible to add this function on the next E2guardian release or it's impossible?

Anthony

@philipianpearce
Copy link
Contributor

philipianpearce commented Oct 30, 2018

I have looked at the code and this is a bug - currently all authplugins configuration are only loaded at start-up. This has been the case since v4.0. The gentle restart (-g) option has never reloaded auth-plugins and previous to v5 only reloaded lists.

v5 introduced fn.conf, lists from e2guardian.conf and storyboard re-reading on -g/-r, but reload of authplugs configuration was missed!

It is possible to add this function and it will be fixed in the next release (v5.3).

Note the -g and -r options have exactly the same function since v4.0. Both have been retained for backward compatibility with control scripts etc.

@Anthony-76
Copy link
Author

Hi @philipianpearce ,

Thanks for your answer.

If you want, I can make some tests for your pre-release.

Anthony

@philipianpearce
Copy link
Contributor

Fixed in v5.4.dev?? Please test - note changes to auth plug-in list defines and plug-in .conf files and pre-auth.story storyboard

@Anthony-76
Copy link
Author

I will try as soon as possible (maybe the next week)

@Anthony-76
Copy link
Author

I just test with the last 5.4-dev.

Like in release 5.3, I must restart e2guardian in order to change IP addresse from group to other group.

The e2guardian -r or service e2gaurdian reload don't reload my modification

@philipianpearce
Copy link
Contributor

philipianpearce commented Nov 4, 2019 via email

@Anthony-76
Copy link
Author

Hi @philipianpearce

Yes, excatly. I use ipmaplist and pre-auth.story

However, I use non transparent proxy (without other parent proxy like Squid). Maybe is the cause of my issue?

So E2Guardian 5.4-dev in installed on Debian10 with the following "./configure"

e2guardian 5.4.0

Built with: '--prefix=/usr' '--enable-clamd=yes' '--with-proxyuser=e2guardian' '--with-proxygroup=e2guardian' '--sysconfdir=/etc' '--localstatedir=/var' '--enable-icap=yes' '--enable-commandline=yes' '--enable-email=yes' '--enable-ntlm=yes' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--enable-pcre=yes' '--enable-sslmitm=yes' 'CPPFLAGS=-mno-sse2 -g -O2'

Thank you

Anthony

@philipianpearce
Copy link
Contributor

@Anthony-76

Is this now fixed for you, can I close?

@Anthony-76
Copy link
Author

Hi @philipianpearce

Sorry for the delay.
Currently I have no free time to test.
In my last comment, it was not fixed.

I will try to test as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants