SDSTOR-22636: support yield leader to a specific candidate#430
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the HomeObject Homestore backend’s operational/debug HTTP APIs by (1) allowing leadership yield to a specific Raft peer (optional candidate) and (2) returning richer shard metadata in shard inspection endpoints.
Changes:
- Add optional
candidatesupport for yielding PG leadership to a specific peer (HTTP + backend plumbing). - Enhance shard inspection responses (
get_shard,dump_chunk,dump_shard) to includelast_modified_timeand shardmeta. - Bump Conan package version to
4.1.18.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/lib/homestore_backend/hs_pg_manager.cpp |
Extends PG leadership yielding to optionally target a specified candidate peer. |
src/lib/homestore_backend/hs_http_manager.cpp |
Adds candidate query param validation/handling for leadership yield; returns additional shard fields in shard/chunk dump APIs. |
src/lib/homestore_backend/hs_homeobject.hpp |
Updates method signatures to accept optional leadership-yield candidate. |
src/lib/homestore_backend/hs_homeobject.cpp |
Threads the optional candidate through to the PG-level yield implementation. |
conanfile.py |
Version bump to reflect the new API capabilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
also return more shard details on get_shard/dump_chunk/dump_shard API
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #430 +/- ##
==============================================
Coverage ? 54.20%
==============================================
Files ? 36
Lines ? 5396
Branches ? 679
==============================================
Hits ? 2925
Misses ? 2164
Partials ? 307 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Besroy
added a commit
to Besroy/HomeObject
that referenced
this pull request
Jun 8, 2026
also return more shard details on get_shard/dump_chunk/dump_shard API Co-authored-by: yawzhang <yawzhang@ebay.com>
Besroy
added a commit
that referenced
this pull request
Jun 8, 2026
also return more shard details on get_shard/dump_chunk/dump_shard API Co-authored-by: yawzhang <yawzhang@ebay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also return more shard details on get_shard/dump_chunk/dump_shard API