Fixed typographical error, changed architechture to architecture in README. #14

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@orthographic-pedant

@eBay, I've corrected a typographical error in the documentation of the restcommander project. You should be able to merge this pull request automatically. However, if this was intentional or if you enjoy living in linguistic squalor, please let me know and create an issue on my home repository.

@jeffpeiyt

This comment has been minimized.

Show comment
Hide comment
@jeffpeiyt

jeffpeiyt Sep 30, 2015

Thanks orthographic-pedant for your contribution. Thanks!

Thanks orthographic-pedant for your contribution. Thanks!

@jeffpeiyt jeffpeiyt closed this Sep 30, 2015

@jeffpeiyt

This comment has been minimized.

Show comment
Hide comment
@jeffpeiyt

jeffpeiyt Sep 30, 2015

somehow I cannot merge them as the repo you come from is gone. I will make the change directly

somehow I cannot merge them as the repo you come from is gone. I will make the change directly

@thoppe

This comment has been minimized.

Show comment
Hide comment
@thoppe

thoppe Oct 1, 2015

@jeffpeiyt That's interesting. I delete the repo as soon as the pull request is made. A few hundred other people have been able to make the merge successfully and yet and handle of them, like yourself, have this problem. If you have any insight into this please open up an issue!

thoppe commented Oct 1, 2015

@jeffpeiyt That's interesting. I delete the repo as soon as the pull request is made. A few hundred other people have been able to make the merge successfully and yet and handle of them, like yourself, have this problem. If you have any insight into this please open up an issue!

@thoppe

This comment has been minimized.

Show comment
Hide comment
@thoppe

thoppe Oct 1, 2015

I think I see the problem. It happens if the issue is closed before a merge. Since the goal is to serve as a public service anyways, I'm OK if I don't get the commit record. Thanks!

thoppe commented Oct 1, 2015

I think I see the problem. It happens if the issue is closed before a merge. Since the goal is to serve as a public service anyways, I'm OK if I don't get the commit record. Thanks!

@jeffpeiyt

This comment has been minimized.

Show comment
Hide comment
@jeffpeiyt

jeffpeiyt Oct 1, 2015

@thoppe Thanks Travis again for your support! We are planning a release of Commander as a core library in a month with almost 50% rewriting code and tons of new features, plus 85%+ test coverage. Most importantly with the new library we restructure it so that ebay/internal are no longer two branches.
We learned a lot from the experience. Will keep you posted on the new one :-)

@thoppe Thanks Travis again for your support! We are planning a release of Commander as a core library in a month with almost 50% rewriting code and tons of new features, plus 85%+ test coverage. Most importantly with the new library we restructure it so that ebay/internal are no longer two branches.
We learned a lot from the experience. Will keep you posted on the new one :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment