mailgun + translation #7

Open
wants to merge 8 commits into
from

Projects

None yet

4 participants

@agborkowski

No description provided.

@eLod
Owner

hey sorry for such a long time without response.

first thank you for your PR, can you please rebase onto my master without the other commits, they seem to be in conflict with the current codebase?

also why not simply add all the aliases? e.g. this->outputFilters += compact('h'') + Message::aliases() + $this->_config['outputFilters'];? (or even putting them into _config['outputFilters'] in _init())

@flazer

With this solution about overwriting $t you are not able to use placeholders in translated text. So one possibility is to use "return" in this closure instead of echo, or just delete $t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment