Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vis: Inherited attributes are visualised #108

Open
anthonyanjorin opened this Issue Aug 22, 2018 · 3 comments

Comments

Projects
None yet
7 participants
@anthonyanjorin
Copy link
Contributor

anthonyanjorin commented Aug 22, 2018

Not sure how to deal with this. Right now all attributes of an EClass are visualised both inherited and non-inherited attributes. I don't think users expect to see inherited attributes (as this is also not the usual case in OO languages). We could of course also make this configurable.

@anthonyanjorin

This comment has been minimized.

Copy link
Contributor Author

anthonyanjorin commented Aug 22, 2018

What do you think @eTralse ?

@eTralse

This comment has been minimized.

Copy link
Collaborator

eTralse commented Aug 23, 2018

As a developer inspecting a class diagram, I wouldn't want inherited attributes to be displayed in a sub-class. On the other hand, there is no way now to identify inherited attributes in the parent class either, if the inherited attributes are not visualized in sub-classes. To solve this problem, one could use the proper modifier icons (i.e. for protected), which are already given in PlantUML.

For the implementation I would recommend to extend the ClassDiagram class to store an EClass to EAttribute mapping (or likewise implementation), to state which EAttributes are to be visualized for which EClass, thus reducing control-flow logic in the PlantUML generator. The determination of the EAttributes could then be realized in the Metamodel visualiser?

@anthonyanjorin

This comment has been minimized.

Copy link
Contributor Author

anthonyanjorin commented Nov 27, 2018

Any progress on this issue? Have you been able to reproduce? Can you suggest a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.