Fix cross-compilation by forwarding cmake_toolchain_file #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, compiler detection fails for eprosima libraries since the toolchain file, which may contain the sysroot path necessary for compilation to work properly, is not forwarded to cmake.
|
See this comment for more details about the build failure that this PR is trying to address: |
|
Sorry for the delay. We had drastic changes on the file you are modifying in an internal branch. Now we are not using Add_ExternalProjectAdd. Instead of it we are using add_subdirectory and those kind of configuration parameters now are not needed to be passed. These changes are already on master branch. I hope it works for you. |
|
Thanks. I'll close the PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, compiler detection fails for eprosima libraries
since the toolchain file, which may contain the sysroot path necessary
for compilation to work properly, is not forwarded to cmake.