Fix fragmentation first fragment size #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Build status:
|
|
Build status:
|
|
Build status:
|
pablogs9
force-pushed
the
fix/serialization_first_fragment
branch
from
54ba367
to
256e04b
Compare
|
Build status:
|
|
Build status:
|
|
Build status:
|
|
Build status:
|
jamoralp
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a regression tests and fixes a bug that does not take into account the submessage fragment size in cases when the first fragment of a fragmented is not written in an empty buffer.
This fix should make micro-ROS/rmw_microxrcedds#84 not necessary