Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fragmentation first fragment size #175

Merged
merged 4 commits into from Nov 18, 2020

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Nov 18, 2020

This PR adds a regression tests and fixes a bug that does not take into account the submessage fragment size in cases when the first fragment of a fragmented is not written in an empty buffer.

This fix should make micro-ROS/rmw_microxrcedds#84 not necessary

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 force-pushed the fix/serialization_first_fragment branch from 54ba367 to 256e04b Compare November 18, 2020 14:48
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Windows Build Status

@jamoralp jamoralp merged commit 304cc26 into develop Nov 18, 2020
@jamoralp jamoralp deleted the fix/serialization_first_fragment branch November 18, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants