Fix discovery deserialization #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
jamoralp
reviewed
Nov 20, 2020
|
Build status:
|
jamoralp
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the deserialization function for Transports locators. This function is used when Agent send the response to the discovery messages.
By default UXR_TRANSPORT_LOCATOR_SEQUENCE_MAX is set to 4 and if the Agent has more interfaces than this, the client won't deserialize none of them.
I propose that, if this does not interfere with any other feature, we can deserialize at least UXR_TRANSPORT_LOCATOR_SEQUENCE_MAX when the agent send more than this.
Also we can write a deserialization function specificallty for this case where this is taken into accoun.
Thoughs?