Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes memory leak due to not deleting freertos socket set #270

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

bjv-capra
Copy link
Contributor

This is an issue that probably went over the top of the head of everyone as this transport was added before the "ping" util was added.

However, when using the "Ping" it'd create a socket and a socket set to do Select, to later never release the socket set.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

Signed-off-by: Bart Jimenez Vera <bjv@capra.ooo>
@pablogs9 pablogs9 changed the base branch from master to develop October 11, 2021 06:07
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@bjv-capra
Copy link
Contributor Author

How soon can we expect this PR to be backported to galactic (foxy)? We can run with the custom change for now, but we'd prefer to use the CI-generated library we have.

@pablogs9
Copy link
Member

As soon as this is merged it will be in foxy and galactic.

@Acuadros95 take a look here please

@Acuadros95
Copy link
Contributor

LGTM

@Acuadros95 Acuadros95 merged commit 743f508 into eProsima:develop Oct 11, 2021
roncapat pushed a commit to roncapat/Micro-XRCE-DDS-Client that referenced this pull request Nov 14, 2021
Signed-off-by: Bart Jimenez Vera <bjv@capra.ooo>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
roncapat pushed a commit to roncapat/Micro-XRCE-DDS-Client that referenced this pull request Nov 15, 2021
Signed-off-by: Bart Jimenez Vera <bjv@capra.ooo>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
pablogs9 pushed a commit that referenced this pull request Nov 15, 2021
* Fixes memory leak due to not deleting freertos socket set (#270)

Signed-off-by: Bart Jimenez Vera <bjv@capra.ooo>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* RTEMS support

Add UCLIENT_PLATFORM_RTEMS_BSD_NET platform flag to use TCP/UDP implementation
with only POSIX API and no poll() usage, to be able to compile against RTEMS 5.1 RTOS.

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Add RTEMS discovery support

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Fix FDSET issue

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Cleanup

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Uncrustify

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Update src/c/profile/transport/ip/tcp/tcp_transport_rtems_bsd_net.c

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Update CMakeLists.txt

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

* Update udp_transport_datagram_rtems_bsd_net.c

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>

Co-authored-by: bjv-capra <80034183+bjv-capra@users.noreply.github.com>
Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
roncapat pushed a commit to roncapat/Micro-XRCE-DDS-Client that referenced this pull request Nov 17, 2021
Signed-off-by: Bart Jimenez Vera <bjv@capra.ooo>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants