Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing declarations of inet_*to* family for POSIX_NOPOLL #272

Merged
merged 1 commit into from Oct 19, 2021
Merged

Fix missing declarations of inet_*to* family for POSIX_NOPOLL #272

merged 1 commit into from Oct 19, 2021

Conversation

roncapat
Copy link
Contributor

Fix #271

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@roncapat
Copy link
Contributor Author

Sorry, @richiprosima, I can't get to the failed Linux built logs. Could you post me a link to the log or a snippet?

@roncapat
Copy link
Contributor Author

I found only the following failures:

FAIL: src/c/core/session/write_access.c (File size changed from 8645 to 8637)
FAIL: src/c/core/session/stream/input_reliable_stream.c (File size changed from 8052 to 8048)

@pablogs9 pablogs9 changed the base branch from master to develop October 18, 2021 14:11
@pablogs9
Copy link
Member

Target branch moved to develop and rebased branch

@pablogs9
Copy link
Member

We should test this in ESP-IDF before merging: micro-ROS/micro_ros_espidf_component#101

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9
Copy link
Member

Could you please @roncapat solve the DCO issue?

@roncapat
Copy link
Contributor Author

Yep, in 30 minutes. I'm on mobile.

@pablogs9
Copy link
Member

micro-ROS/micro_ros_espidf_component#101 Seems to build ok, so LGTM

@roncapat
Copy link
Contributor Author

All good on micro-ROS/micro_ros_espidf_component#101 side.
Sorry for DCO, when I can get back to my PC I solve.

@roncapat
Fix missing declarations of inet_*to* family for POSIX_NOPOLL
f55ff0b 
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9 pablogs9 merged commit b8f251d into eProsima:develop Oct 19, 2021
@pablogs9 pablogs9 mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

@Acuadros95 Acuadros95 Acuadros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with UCLIENT_PLATFORM_POSIX_NOPOLL flag
4 participants
@roncapat @richiprosima @pablogs9 @Acuadros95