New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXE in RESTServer.java #2180

Closed
ProDigySML opened this Issue Sep 29, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@ProDigySML
Copy link

ProDigySML commented Sep 29, 2018

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred

The following code snippets display the usage of XMLReader without securely disabling entities:

nsExtractor.parse(src);

The insecure XML parsing is used within the REST server in the following code:

variables = parseXML(_var, nsExtractor);

@dizzzz

This comment has been minimized.

Copy link
Member

dizzzz commented Sep 29, 2018

I am pretty sure things have already been fixed with #2145 @adamretter

@ProDigySML

This comment has been minimized.

Copy link

ProDigySML commented Sep 30, 2018

@dizzzz Unfortunately the parser here is different to what has been patched previously (as far as I know).
image

@dizzzz

This comment has been minimized.

Copy link
Member

dizzzz commented Sep 30, 2018

Right you are! we should get the XMLparser here from the pool too... @adamretter @wolfgangmm

@dizzzz

This comment has been minimized.

Copy link
Member

dizzzz commented Sep 30, 2018

please could you file this issue at security@exist-db.org ?

adamretter added a commit to adamretter/exist that referenced this issue Oct 30, 2018

adamretter added a commit to adamretter/exist that referenced this issue Oct 30, 2018

adamretter added a commit to adamretter/exist that referenced this issue Oct 30, 2018

adamretter added a commit to adamretter/exist that referenced this issue Oct 30, 2018

@dizzzz dizzzz closed this in #2243 Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment