New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test showing problem with dynamic context in range:index-keys-for-field #1227

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
4 participants
@olvidalo
Contributor

olvidalo commented Jan 15, 2017

demonstrates issue in #1226

@olvidalo olvidalo changed the title from Add test showing problem with dynamic contests in range:index-keys-for-field to Add test showing problem with dynamic context in range:index-keys-for-field Jan 15, 2017

@dizzzz dizzzz requested a review from wolfgangmm Jan 15, 2017

@shabanovd

This comment has been minimized.

Member

shabanovd commented Jan 16, 2017

hmm, tests pass on CI

@dizzzz

This comment has been minimized.

Member

dizzzz commented Jan 16, 2017

Probably the invocation of the script need to be configured. I remember a file for this....

@olvidalo

This comment has been minimized.

Contributor

olvidalo commented Jan 16, 2017

I just added the pending annotation because @joewiz did it in #1177 and I thought this must be common practise. Apparently it isn't :) Pending tests don't get executed at all but show up in the report as such. So this could be merged even before fixing the bug without breaking CI. Might be useful as this contains some passing tests for range:index-keys-for-field which hadn't been tested before.

But I can remove the %pending of course. Let me know..

@dizzzz

This comment has been minimized.

Member

dizzzz commented Jan 16, 2017

I missed the %pending part :-)

@wolfgangmm wolfgangmm merged commit 18f9b53 into eXist-db:develop Jan 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment