New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] xmldb:find-last-modified-until #1425

Merged
merged 4 commits into from Apr 25, 2017

Conversation

Projects
None yet
2 participants
@olvidalo
Copy link
Contributor

olvidalo commented Apr 25, 2017

Adds xmldb:find-last-modified-until analogous to the already existing xmldb:find-last-modified-since.

Also fixes the documentation for the return value of find-last-modified-since and adds tests for both functions.


test:suite(util:list-functions("http://exist-db.org/testsuite/permissions"))
test:suite((
(: inspect:module-functions(xs:anyURI("permission-tests.xql")),:)

This comment has been minimized.

@adamretter

adamretter Apr 25, 2017

Member

Just wondering why the permission-tests are commented out now?

This comment has been minimized.

@olvidalo

olvidalo Apr 25, 2017

Contributor

Ooops! I've amended the testsuite commit.

@@ -0,0 +1,83 @@
package org.exist.xquery.functions.xmldb;

This comment has been minimized.

@adamretter

adamretter Apr 25, 2017

Member

Could you add the standard copyright header?

@adamretter

This comment has been minimized.

Copy link
Member

adamretter commented Apr 25, 2017

@olvidalo Looks good. Just a couple of comments...

@olvidalo olvidalo force-pushed the olvidalo:feature/last-modified-until branch from 1a73a0d to 8c088a7 Apr 25, 2017

@adamretter adamretter merged commit 9390432 into eXist-db:develop Apr 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adamretter

This comment has been minimized.

Copy link
Member

adamretter commented Apr 25, 2017

@olvidalo Thanks for your contribution :-)

@olvidalo

This comment has been minimized.

Copy link
Contributor

olvidalo commented Apr 25, 2017

Wow that was quick. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment