New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Journal of binary documents #1871

Merged
merged 3 commits into from May 13, 2018

Conversation

Projects
None yet
2 participants
@adamretter
Member

adamretter commented May 12, 2018

Just tests...

@wolfgangmm this might be useful for you when trying to figure out the XML Document Recovery Corruptions. You could implement a JournalXMLTest extends AbstractJournalTest in s similar vein to how test/src/org/exist/storage/journal/JournalBinaryTest.java works.

@adamretter adamretter added this to the eXist-4.1.1 milestone May 12, 2018

@adamretter adamretter requested a review from dizzzz May 12, 2018

@dizzzz

This comment has been minimized.

Member

dizzzz commented May 12, 2018

The PR shows issues.... needs rework?

@dizzzz

travis build is not OK :-(

@adamretter adamretter force-pushed the adamretter:feature/test-journal branch from 11a1449 to 65fa7b7 May 13, 2018

@adamretter

This comment has been minimized.

Member

adamretter commented May 13, 2018

@dizzzz Fixed. Sorry about that, build/scripts/junit.xml was executing the abstract class too which is not possible. I added it to the exclusions now and all works well.

@dizzzz dizzzz merged commit 06b8903 into eXist-db:develop May 13, 2018

2 of 3 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adamretter adamretter deleted the adamretter:feature/test-journal branch May 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment