Optimize fn:subsequence #1977
Merged
Optimize fn:subsequence #1977
Conversation
… xs:integer not Java int. We actually use Java long here as a compromise
…ypes. This can lead to an optimisation for fn:subsequence with a large $startingLoc
…ence of a sequence
adamretter
force-pushed the
adamretter:hotfix/subsequence-memory-use
branch
from
bab5831
to
24a7b91
This was referenced Sep 2, 2018
|
@dizzzz @wolfgangmm I think this is now ready to merged (pending review and CI of course!) |
|
Nice piece of work! |
|
All tests pass.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes #1971
Details are written up here: https://blog.adamretter.org.uk/fixing-existdb-range-oom/