Skip to content

Optimize fn:subsequence #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dizzzz merged 15 commits into from
Sep 3, 2018
Merged

Optimize fn:subsequence #1977

dizzzz merged 15 commits into from
Sep 3, 2018

Conversation

@adamretter
Copy link
Contributor

@adamretter adamretter commented Jun 28, 2018 •
edited
Loading

@adamretter adamretter added bug issue confirmed as bug enhancement new features, suggestions, etc. high prio in progress Issue is actively being worked upon labels Jun 28, 2018
@adamretter adamretter added this to the eXist-5.0.0 milestone Jun 28, 2018
@adamretter adamretter requested review from dizzzz and wolfgangmm June 29, 2018 17:08
@adamretter adamretter removed the in progress Issue is actively being worked upon label Sep 2, 2018
@adamretter
[ignore] code cleanup
2454aa3
@adamretter
[test] Tests for xs:double
5f7288f
@adamretter
[bugfix] Don't realize sequence when generating a string description …
fa9c230 
…of RangeSequence
@adamretter
[bugfix] fn:subsequence requires xs:double arguments to be rounded to…
ffaf576 
… xs:integer not Java int. We actually use Java long here as a compromise
@adamretter
[refactor] Cleanup the start and length calulations in fn:subsequence
cb8d626
@adamretter
[bugfix] xs:integer is unbounded
6673e0e
@adamretter
[feature] Optimize RangeSequence for fn:subsequence with a large $sta…
1e52c40 
…rtingLoc
@adamretter
[feature] Impelement SequenceIterator#skip(long) for other Sequence t…
0089edd 
…ypes. This can lead to an optimisation for fn:subsequence with a large $startingLoc
@adamretter
[feature] Small optimisation for Range Sequences
42a6808
@adamretter
[feature] A new type of Sequence which dynamically provides a subsequ…
2440d21 
…ence of a sequence
@adamretter
[bugfix] RangeSequence could return one more entry than it should via…
cdfba67 
… #itemAt(long)
@adamretter
[refactor] Allow Sequences to have a length of more than 2^32-1
cc0a5bf
@adamretter
[optimization] Make fn:subsequence lazily evaluated
c262649
@adamretter
[bugfix] Cardinality should return MANY not ONE_OR_MORE when there is…
24a7b91 
… 1+n items
@adamretter adamretter force-pushed the hotfix/subsequence-memory-use branch from bab5831 to 24a7b91 Compare September 2, 2018 19:34
This was referenced Sep 2, 2018
Merged
Merged
@adamretter
Copy link
Contributor Author

adamretter commented Sep 2, 2018

@dizzzz @wolfgangmm I think this is now ready to merged (pending review and CI of course!)

dizzzz
dizzzz approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of work!

@dizzzz
Copy link
Member

dizzzz commented Sep 3, 2018

All tests pass....

@dizzzz dizzzz merged commit ec5b16a into eXist-db:develop Sep 3, 2018
@adamretter adamretter deleted the hotfix/subsequence-memory-use branch September 25, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizzzz dizzzz dizzzz approved these changes

@wolfgangmm wolfgangmm Awaiting requested review from wolfgangmm

Assignees

No one assigned

Labels

bug issue confirmed as bug enhancement new features, suggestions, etc. high prio

Projects

None yet

Milestone

eXist-5.1.0

Development

Successfully merging this pull request may close these issues.

Large XQuery range can crash eXist-db

2 participants

@adamretter @dizzzz