Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] implemented xquery function json-to-xml #3093

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@windauer
Copy link
Member

windauer commented Nov 4, 2019

Description:

Implemented fn:json-to-xml

Reference:

Specification

Type of tests:

XQSuite: exist-core/src/test/xquery/xquery3/json-to-xml.xql

@windauer windauer requested review from wolfgangmm and dizzzz Nov 4, 2019
@dizzzz
dizzzz approved these changes Nov 4, 2019
Copy link
Member

dizzzz left a comment

lgtm ;



declare
%test:assertEquals("<fn:map xmlns:fn='http://www.w3.org/2005/xpath-functions'><fn:number key='x'>1</fn:number><fn:array key='y'><fn:number>3</fn:number><fn:number>4</fn:number><fn:number>5</fn:number></fn:array></fn:map>")

This comment has been minimized.

Copy link
@dizzzz

dizzzz Nov 4, 2019

Member

during development of the mongodb and couchbase drivers, I found several issues while parsing complexer structures (deeper, nested). You might want to test these as well.

This comment has been minimized.

Copy link
@joewiz

joewiz Nov 4, 2019

Member

If we can get the XQuery test suite runner working under eXist 5.0.0, I think we could be confident: eXist-db/exist-xqts-runner#7.

@dizzzz
dizzzz approved these changes Nov 4, 2019
Copy link
Contributor

duncdrum left a comment

Please open a docs PR link is in the comments.

@windauer

This comment has been minimized.

Copy link
Member Author

windauer commented Dec 4, 2019

updated the documentation ( eXist-db/documentation#409 ) and followed the stylistic suggestion from @joewiz but in the order @adamretter proposed ;)

@duncdrum duncdrum merged commit d63f2c8 into eXist-db:develop Dec 5, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.