Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] New implementation of fn:format-number #3130

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@adamretter
Copy link
Member

adamretter commented Nov 27, 2019

Closes #383

This is now complete, or as complete as it can be right now. We are passing 96.15% of XQTS 3.1:

Screenshot 2019-12-06 at 16 19 43

There are three types of remaining test failures, which I am not going to address. I will leave these for others:

  1. XQTS 3.1 - numberformat901err
    This fails as our XQuery parser does not implement declare default decimal-format. Perhaps @line-o or someone wants to add that to the pars er?
  2. XQTS 3.1 - numberformat63 and numberformat64
    These failures are related to numeric precision. I suspect eXIst-db has problems with this elsewhere.
  3. format-numbers.xql - fd:invalid-picture
    I am not sure if that is an invalid picture. Certainly I can't see why the spec of fn:format-number would forbid that. Perhaps @duncdrum or @joewiz would be interested to check that.
@adamretter adamretter added this to the eXist-5.1.1 milestone Nov 27, 2019
@adamretter adamretter force-pushed the adamretter:hotfix/fn-format-number branch 2 times, most recently from c4c4ac8 to 2fcf3c6 Nov 29, 2019
@dizzzz
dizzzz approved these changes Dec 2, 2019
@adamretter adamretter force-pushed the adamretter:hotfix/fn-format-number branch 3 times, most recently from 8f206ba to 42f3e47 Dec 4, 2019
@adamretter adamretter force-pushed the adamretter:hotfix/fn-format-number branch from 42f3e47 to f0d36f0 Dec 6, 2019
@eXist-db eXist-db deleted a comment from dizzzz Dec 6, 2019
@adamretter adamretter added enhancement and removed bug labels Dec 6, 2019
@adamretter adamretter requested a review from eXist-db/core Dec 6, 2019
@joewiz joewiz merged commit e0ac339 into eXist-db:develop Dec 6, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
@joewiz

This comment has been minimized.

Copy link
Member

joewiz commented Dec 6, 2019

Note from @adamretter via Slack:

It has passed Travis-CI. I don't expect anything platform specific, so we could skip waiting for AppVeyor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.