Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent modification shutting down multiple broker pools #3145

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@reinhapa
Copy link
Contributor

reinhapa commented Dec 6, 2019

Description:

Fixes a race condition when having multiple database instances and therefore multiple broker pools being shut down concurrently leading to a ConcurrentModificationException

Type of tests:

BrokerPoolsTest reproducing the race condition

@reinhapa reinhapa force-pushed the BisonSchweizAG:concurrent_shutdown branch from 904cc0b to 6bb03c6 Dec 6, 2019
@dizzzz dizzzz requested a review from adamretter Dec 6, 2019
@dizzzz
dizzzz approved these changes Dec 6, 2019
@adamretter adamretter changed the title [bugfix] Fix concurrent modification shutting down multiple broker pools Fix concurrent modification shutting down multiple broker pools Dec 6, 2019
Copy link
Member

adamretter left a comment

Nice catch!

@adamretter adamretter merged commit 3bfc7dc into eXist-db:develop Dec 6, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build cancelled
Details
Travis CI - Pull Request Build Passed
Details
@reinhapa reinhapa deleted the BisonSchweizAG:concurrent_shutdown branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.