Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc code improvements #3178

Merged
merged 22 commits into from Jan 22, 2020
Merged

Conversation

@dizzzz
Copy link
Member

dizzzz commented Dec 30, 2019

End-of-year Code cleanup, mechanical refactoring mostly.
Happy 2020 !

dizzzz added 21 commits Dec 11, 2019
…_code_improvements

* 'develop' of github.com:eXist-db/exist:
  Bump rsyntaxtextarea from 3.0.4 to 3.0.6
  Bump jetty.version from 9.4.24.v20191120 to 9.4.25.v20191220
  Bump maven-source-plugin from 3.2.0 to 3.2.1
  Implements isOpen() / close() methods on RemoteCollection
  Bump slf4j-api from 1.7.29 to 1.7.30
  Bump log4j.version from 2.12.1 to 2.13.0

# Conflicts:
#	exist-core/src/main/java/org/exist/xmldb/RemoteIndexQueryService.java
#	exist-core/src/main/java/org/exist/xmldb/RemoteResourceSet.java
#	exist-core/src/main/java/org/exist/xmldb/RemoteUserManagementService.java
improved Switch code
…t by checking internal administration, no more expensive compare operation is needed)
…because it would become less readable)
@dizzzz dizzzz requested a review from adamretter Dec 30, 2019
@dizzzz dizzzz marked this pull request as ready for review Dec 30, 2019
@dizzzz dizzzz requested review from wolfgangmm, duncdrum and ljo Dec 30, 2019
Copy link
Contributor

duncdrum left a comment

looks good

@dizzzz dizzzz added the enhancement label Jan 4, 2020
@dizzzz dizzzz added this to the eXist-5.1.2 milestone Jan 17, 2020
@dizzzz

This comment has been minimized.

Copy link
Member Author

dizzzz commented Jan 17, 2020

@adamretter

This comment has been minimized.

Copy link
Member

adamretter commented Jan 21, 2020

@dizzzz I am slowly working my way through it... the change-set is huge ;-)

Copy link
Member

adamretter left a comment

A lot of very good small changes to make the code more readable and compact.

Spotted just two small things ;-)

@dizzzz

This comment has been minimized.

Copy link
Member Author

dizzzz commented Jan 21, 2020

Thnx @adamretter waiting for build to finish....

@dizzzz

This comment has been minimized.

Copy link
Member Author

dizzzz commented Jan 21, 2020

image

@dizzzz

This comment has been minimized.

Copy link
Member Author

dizzzz commented Jan 22, 2020

All green !

@joewiz joewiz merged commit 2909a75 into eXist-db:develop Jan 22, 2020
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@dizzzz dizzzz deleted the dizzzz:feature/misc_code_improvements branch Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.