Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastStringBuffer improvement #3186

Merged
merged 5 commits into from Jan 18, 2020

Conversation

@dizzzz
Copy link
Member

dizzzz commented Jan 5, 2020

Improved performance by using native array copy
Synced code from saxonHE
Added tests

Improved performance by using native array copy
Added tests
@dizzzz dizzzz added the enhancement label Jan 5, 2020
@dizzzz dizzzz requested review from wolfgangmm and adamretter Jan 5, 2020
Copy link
Member

adamretter left a comment

In general it looks good - love the tests.

Just wondering about the StringBuilder thing

dizzzz added 4 commits Jan 16, 2020
Added mode support
Code cleanup
@dizzzz

This comment has been minimized.

Copy link
Member Author

dizzzz commented Jan 16, 2020

@adamretter reworked PR, added some additional improvements that might yield in less overhead (less code execution, stack usage, unneeded conversation to objects etc)

@dizzzz dizzzz modified the milestones: eXist-5.1.2, eXist-5.2.0 Jan 17, 2020
@adamretter adamretter merged commit a87dc29 into eXist-db:develop Jan 18, 2020
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@adamretter

This comment has been minimized.

Copy link
Member

adamretter commented Jan 18, 2020

Excellent stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.