Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to log at the correct level #3200

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@adamretter
Copy link
Member

adamretter commented Jan 15, 2020

Closes #2622

@adamretter adamretter added the bug label Jan 15, 2020
@adamretter adamretter added this to the eXist-5.1.2 milestone Jan 15, 2020
@adamretter adamretter requested a review from eXist-db/core Jan 15, 2020
@@ -140,7 +142,9 @@ public Expression getFirst() {
public void remove(final Expression oldExpr) {
final int idx = steps.indexOf(oldExpr);
if (idx < 0) {
LOG.warn("Expression to remove not found: " + ExpressionDumper.dump(oldExpr) + "; in: " + ExpressionDumper.dump(this));
if (LOG.isTraceEnabled()) {
LOG.trace("Expression not found when trying to remove: " + ExpressionDumper.dump(oldExpr) + "; in: " + ExpressionDumper.dump(this));

This comment has been minimized.

Copy link
@dizzzz

dizzzz Jan 15, 2020

Member

LOG.trace("{} {}") ?

@adamretter adamretter force-pushed the adamretter:hotfix/not-warning branch from be06d7d to afb5ec8 Jan 15, 2020
@adamretter

This comment has been minimized.

Copy link
Member Author

adamretter commented Jan 15, 2020

@dizzzz I have now made the changes as you suggested.

@dizzzz
dizzzz approved these changes Jan 16, 2020
@dizzzz dizzzz merged commit f892c71 into eXist-db:develop Jan 16, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.