Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contentextraction on 5.x.x #3206

Merged
merged 2 commits into from Jan 21, 2020

Conversation

@adamretter
Copy link
Member

adamretter commented Jan 17, 2020

Closes #3166

@joewiz

This comment has been minimized.

Copy link
Member

joewiz commented on 2f6ba52 Jan 15, 2020

Ooh, thanks for digging into this, Adam!

@adamretter adamretter added the bug label Jan 17, 2020
@adamretter adamretter added this to the eXist-5.1.2 milestone Jan 17, 2020
@adamretter adamretter requested a review from eXist-db/core Jan 17, 2020
@dizzzz
dizzzz approved these changes Jan 17, 2020
Copy link
Member

dizzzz left a comment

restarting build:

ERROR] Unable to resolve system scoped dependency: com.sun:tools:jar:1.8.0:system
313[ERROR] Failed to execute goal org.owasp:dependency-check-maven:5.2.4:check (default) on project exist-contentextraction: One or more exceptions occurred during dependency-check analysis: One or more exceptions occurred during analysis:
314[ERROR] 	Unable to resolve system scoped dependency: com.sun:tools:jar:1.8.0:system
@adamretter adamretter force-pushed the adamretter:hotfix/content-extraction-npe branch 2 times, most recently from 835f8b7 to 98b1ec9 Jan 18, 2020
… Content Extraction Module

Closes #3166
@adamretter adamretter force-pushed the adamretter:hotfix/content-extraction-npe branch from 98b1ec9 to 7481aa8 Jan 20, 2020
@adamretter

This comment has been minimized.

Copy link
Member Author

adamretter commented Jan 21, 2020

@dizzzz this is now passing all tests :-)

@dizzzz
dizzzz approved these changes Jan 21, 2020
@dizzzz dizzzz merged commit 6ca079c into eXist-db:develop Jan 21, 2020
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.