Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to make Document locks hierarchical #3208

Merged
merged 1 commit into from Jan 22, 2020

Conversation

@adamretter
Copy link
Member

adamretter commented Jan 18, 2020

This adds a new option to conf.xml:

<document use-path-locks="false"/>

When this is enabled, document and collection locks participate in the same locking hierarchy. This means that it becomes impossible for deadlocks to occur between documents and collections.

This should likely be enabled by default in future.

@adamretter adamretter added this to the eXist-5.1.2 milestone Jan 18, 2020
@adamretter adamretter requested a review from eXist-db/core Jan 18, 2020
Copy link
Contributor

duncdrum left a comment

I need some time to wrap my head around this. But at a minimum the sample conf.xml in the docs needs to be updated to match the new one. More prose would always be good.

Copy link
Member

dizzzz left a comment

image

@adamretter adamretter force-pushed the adamretter:feature/document-lock-hierarchy branch from 9b1dfe7 to e153830 Jan 21, 2020
@adamretter

This comment has been minimized.

Copy link
Member Author

adamretter commented Jan 21, 2020

@adamretter

This comment has been minimized.

Copy link
Member Author

adamretter commented Jan 22, 2020

@duncdrum can we get this one merged now?

@dizzzz
dizzzz approved these changes Jan 22, 2020
@dizzzz
dizzzz approved these changes Jan 22, 2020
@dizzzz
dizzzz approved these changes Jan 22, 2020
@dizzzz dizzzz merged commit 363ed27 into eXist-db:develop Jan 22, 2020
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.