Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a concurrency issue in WeakLazyStripes #3219

Merged
merged 1 commit into from Jan 22, 2020
Merged

Fix a concurrency issue in WeakLazyStripes #3219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion exist-core/src/main/java/org/exist/util/WeakLazyStripes.java
View file
Open in desktop
Expand Up @@ -229,7 +229,14 @@ public S get(final K key) {
private @Nullable WeakValueReference<K, S> getOptimistic(final K key, final Holder<Boolean> written) {
// optimistic read
final long stamp = stripesLock.tryOptimisticRead();
WeakValueReference<K, S> stripeRef = stripes.get(key);
WeakValueReference<K, S> stripeRef;
try {
stripeRef = stripes.get(key);
} catch (final ArrayIndexOutOfBoundsException e) {
// this can occur as we don't hold a lock, we just have a stamp for an optimistic read,
// so `stripes` might be concurrently modified
return null;
}
if (stripeRef == null || stripeRef.get() == null) {
final long writeStamp = stripesLock.tryConvertToWriteLock(stamp);
if (writeStamp != 0l) {
Expand Down