Skip to content

Conversation

@adamretter
Copy link
Contributor

@adamretter adamretter commented May 3, 2016

Until now if you set <recovery enabled="no"... in conf.xml then eXist would not start up, instead throwing a series of NullPointerExceptions.

This occurred because the use of Txn has become deeply embedded in eXist, however switching off recovery, would also disable the TransactionManager (i.e. set it to null).

This patch seperates the concerns of Transactions and Recovery. Enabling eXist still to work in terms of Transactions, yet just disabling the journal (and recovery of which) when recovery is disabled in conf.xml.

This PR includes a few pieces of cleanup to related classes, however the main aspect of the change is in the commits:

  1. 5129f36
  2. 6818ed5

@adamretter adamretter added bug issue confirmed as bug enhancement new features, suggestions, etc. labels May 3, 2016
@adamretter adamretter added this to the eXist-3.0 milestone May 3, 2016
@adamretter adamretter force-pushed the transaction-recovery branch from 6818ed5 to 1a88730 Compare May 4, 2016 17:49
@dizzzz
Copy link
Member

dizzzz commented May 7, 2016

@wolfgangmm @ljo @shabanovd ?

@wolfgangmm
Copy link
Member

wolfgangmm commented May 7, 2016

I tested the PR and did not see any negative effects. Seems ok to me.

Ooops, spoke too early. I tested a different one. Will have a look at this one.

@adamretter
Copy link
Contributor Author

@wolfgangmm all good?

@wolfgangmm
Copy link
Member

I'm struggling to get my usual stress tests running on latest develop due to some API changes. I will report once I succeeded.

@joewiz
Copy link
Member

joewiz commented May 9, 2016

A minor typo in the issue title: s/Seperates/Separates.

@adamretter adamretter changed the title Seperates the concerns of Transactions and Recovery Separates the concerns of Transactions and Recovery May 9, 2016
@adamretter
Copy link
Contributor Author

@joewiz Fixed!

@adamretter
Copy link
Contributor Author

@wolfgangmm We had hoped you would open source your stress tests. Then we could help with such changes :-)

@wolfgangmm
Copy link
Member

@adamretter In fact the best and most up to date stress test is currently the one against @joewiz https://history.state.gov site. The code for the entire site is available on github and builds automatically: https://github.com/HistoryAtState/hsg-project. jmeter tests based on real user traffic are here: https://github.com/joewiz/hsg-test/blob/master/src/test/jmeter/combined.jmx. That's basically what I'm testing against most of the time right now. It takes some time to set up, but any stress test which is worth to consider must contain a large amount of data and a representative set of user actions.

@adamretter adamretter force-pushed the transaction-recovery branch 3 times, most recently from 0d90e30 to 9341815 Compare May 13, 2016 22:53
@adamretter
Copy link
Contributor Author

@wolfgangmm any updates on this one?

@wolfgangmm
Copy link
Member

I did not forget it and still have the branch running. I'll try to test it as soon as I can.

@adamretter adamretter force-pushed the transaction-recovery branch from 9341815 to 39bb9ed Compare May 24, 2016 17:06
@wolfgangmm wolfgangmm merged commit b476eb5 into eXist-db:develop May 30, 2016
@adamretter adamretter deleted the transaction-recovery branch May 30, 2016 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug issue confirmed as bug enhancement new features, suggestions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants