New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates the concerns of Transactions and Recovery #989

Merged
merged 7 commits into from May 30, 2016

Conversation

Projects
None yet
4 participants
@adamretter
Member

adamretter commented May 3, 2016

Until now if you set <recovery enabled="no"... in conf.xml then eXist would not start up, instead throwing a series of NullPointerExceptions.

This occurred because the use of Txn has become deeply embedded in eXist, however switching off recovery, would also disable the TransactionManager (i.e. set it to null).

This patch seperates the concerns of Transactions and Recovery. Enabling eXist still to work in terms of Transactions, yet just disabling the journal (and recovery of which) when recovery is disabled in conf.xml.

This PR includes a few pieces of cleanup to related classes, however the main aspect of the change is in the commits:

  1. 5129f36
  2. 6818ed5

@adamretter adamretter added this to the eXist-3.0 milestone May 3, 2016

@adamretter adamretter force-pushed the adamretter:transaction-recovery branch from 6818ed5 to 1a88730 May 4, 2016

@dizzzz

This comment has been minimized.

Member

dizzzz commented May 7, 2016

@wolfgangmm

This comment has been minimized.

Member

wolfgangmm commented May 7, 2016

I tested the PR and did not see any negative effects. Seems ok to me.

Ooops, spoke too early. I tested a different one. Will have a look at this one.

@adamretter

This comment has been minimized.

Member

adamretter commented May 9, 2016

@wolfgangmm all good?

@wolfgangmm

This comment has been minimized.

Member

wolfgangmm commented May 9, 2016

I'm struggling to get my usual stress tests running on latest develop due to some API changes. I will report once I succeeded.

@joewiz

This comment has been minimized.

Member

joewiz commented May 9, 2016

A minor typo in the issue title: s/Seperates/Separates.

@adamretter adamretter changed the title from Seperates the concerns of Transactions and Recovery to Separates the concerns of Transactions and Recovery May 9, 2016

@adamretter

This comment has been minimized.

Member

adamretter commented May 9, 2016

@joewiz Fixed!

@adamretter

This comment has been minimized.

Member

adamretter commented May 9, 2016

@wolfgangmm We had hoped you would open source your stress tests. Then we could help with such changes :-)

@wolfgangmm

This comment has been minimized.

Member

wolfgangmm commented May 9, 2016

@adamretter In fact the best and most up to date stress test is currently the one against @joewiz https://history.state.gov site. The code for the entire site is available on github and builds automatically: https://github.com/HistoryAtState/hsg-project. jmeter tests based on real user traffic are here: https://github.com/joewiz/hsg-test/blob/master/src/test/jmeter/combined.jmx. That's basically what I'm testing against most of the time right now. It takes some time to set up, but any stress test which is worth to consider must contain a large amount of data and a representative set of user actions.

@adamretter adamretter force-pushed the adamretter:transaction-recovery branch 3 times, most recently from 0d90e30 to 9341815 May 9, 2016

@adamretter

This comment has been minimized.

Member

adamretter commented May 18, 2016

@wolfgangmm any updates on this one?

@wolfgangmm

This comment has been minimized.

Member

wolfgangmm commented May 19, 2016

I did not forget it and still have the branch running. I'll try to test it as soon as I can.

@adamretter adamretter force-pushed the adamretter:transaction-recovery branch from 9341815 to 39bb9ed May 24, 2016

@wolfgangmm wolfgangmm merged commit b476eb5 into eXist-db:develop May 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adamretter adamretter deleted the adamretter:transaction-recovery branch May 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment