/eXpansion2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eXpansion crashes with unknown player error #269

Closed
oliverde8 opened this Issue Feb 18, 2018 · 0 comments

Comments

Assignees

@oliverde8 oliverde8

Labels
Projects
None yet
Milestone
  alpha-3
1 participant
@oliverde8
@oliverde8
Member

oliverde8 commented Feb 18, 2018

eXpansion2/src/eXpansion/Framework/Core/Plugins/GuiHandler.php

Line 153 in f3f56a3

$this->connection->sendDisplayManialinkPage(

Need to catch error, sadly not well handled by dedicated it's stupid error that can't be avoided.

image

@oliverde8 oliverde8 added 1. Bug 😭 2. High 👍 labels Feb 18, 2018

@oliverde8 oliverde8 added this to the alpha-3 milestone Feb 18, 2018

@oliverde8 oliverde8 self-assigned this Feb 18, 2018

oliverde8 added a commit that referenced this issue Feb 18, 2018

@oliverde8
#269 - Fixed invalid argument exception error with when null player r… 
…eturned.
Loading status checks…
9689327

@oliverde8 oliverde8 closed this Feb 18, 2018

oliverde8 added a commit that referenced this issue Feb 18, 2018

@oliverde8
Merge pull request #271 from eXpansionPluginPack/fix-269 
#269 - Fixed invalid argument exception error with when null player r…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a89330c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment