/eXpansion2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting data grid numeric values doesn't work as expected. #277

Closed
reaby opened this Issue Feb 19, 2018 · 0 comments

Comments

Assignees

@oliverde8 oliverde8

Labels
Projects
None yet
Milestone
  alpha-3
2 participants
@reaby @oliverde8
@reaby
Contributor

reaby commented Feb 19, 2018

I'm reporting a Bug

Sorting data grid numeric values doesn't work as it should...

Expected behavior:
1-2-3-4-5....10-11-12

Current behavior:
1-10-100-1000-1001-1002..101-102...

image

@oliverde8 oliverde8 self-assigned this Feb 19, 2018

@oliverde8 oliverde8 added 1. Bug 😭 2. Medium good first issue ⚡️ labels Feb 19, 2018

@oliverde8 oliverde8 added this to the alpha-3 milestone Feb 19, 2018

reaby added a commit that referenced this issue Feb 21, 2018

@reaby
Fixed issue #277 - sorting numeric values on datagrids
Loading status checks…
b47eccf

@reaby reaby closed this Feb 21, 2018

oliverde8 added a commit that referenced this issue Feb 23, 2018

@oliverde8
#277 - Added unit test to check sorting in data collections.
Loading status checks…
7df0c48

oliverde8 added a commit that referenced this issue Feb 23, 2018

@oliverde8
#277 - Fixed unit test on sorting.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
19a839f

oliverde8 added a commit that referenced this issue Feb 23, 2018

@oliverde8
#277 - Fixed issue with numeric sorting being inversed
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3983aa7

oliverde8 added a commit that referenced this issue Feb 23, 2018

@oliverde8
Merge pull request #279 from eXpansionPluginPack/fix-#277 
Fixed issue #277 - sorting numeric values on datagrids
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8240721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment